Set tenant admin's password from host side #14597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hikalkan
requested changes
Nov 10, 2022
| @@ -301,4 +302,13 @@ public override async Task<IQueryable<IdentityUser>> WithDetailsAsync() | |||
| { | |||
| return (await GetQueryableAsync()).IncludeDetails(); | |||
| } | |||
|
|
|||
| public virtual async Task<IdentityUser> GetUserByTenantIdAndUserNameAsync(Guid tenantId, [NotNull] string userName, bool includeDetails = true, CancellationToken cancellationToken = default) | |||
There was a problem hiding this comment.
- You've declared, but not used the
includeDetailsparameter. See other similar methods to understand how to use. - If a method may return null, then its name should start with
Find, notGet - A good naming can be
FindByTenantIdAndUserNameAsync. Don't useUser, we are already in the user context.
hikalkan
approved these changes
Nov 10, 2022
hikalkan
requested changes
Nov 10, 2022
| @@ -102,4 +102,11 @@ public interface IIdentityUserRepository : IBasicRepository<IdentityUser, Guid> | |||
| bool? notActive = null, | |||
| CancellationToken cancellationToken = default | |||
| ); | |||
|
|
|||
| Task<IdentityUser> FindByTenantIdAndUserNameAsync( | |||
| Guid tenantId, | |||
There was a problem hiding this comment.
Make the tenantId nullable, so the method can be used for host users too.
hikalkan
approved these changes
Nov 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes https://github.com/volosoft/volo/issues/12067