Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Check latest stable version from a new endpoint #15783

Merged
merged 6 commits into from
Feb 23, 2023

Conversation

EngincanV
Copy link
Member

@EngincanV EngincanV commented Feb 23, 2023

Description

Instead of retrieving the latest stable version from NuGet, from now on we will get it from a new endpoint. After we release a new stable version, we should update the latest-version.json file in the root directory of this repository and when a user runs the CLI it will check from that file.

This will give us time to test new versions before notifying the developers and allow us to take necessary actions if we faced any problems.

I haven't found any other places that make latest stable version check, if you know any other places that we should update, please let me know. @ebicoglu @yekalkan

Checklist

  • I fully tested it as developer / designer and created unit / integration tests
  • I documented it (or no need to document or I will create a separate documentation issue) - no need to document

How to test it?

You can check the following steps for testing this PR:

You can lower your ABP CLI version such as 6.0.0 and run the Volo.Abp.Cli project, after following the steps above.

@EngincanV EngincanV added this to the 7.1-final milestone Feb 23, 2023
@EngincanV EngincanV marked this pull request as ready for review February 23, 2023 10:26
@ebicoglu
Copy link
Member

enrich the json file

if there's message, then write it to the console output

[
	{
		"version": "7.0.2",
		"released-date" : "2023-02-23",
		"type" : "stable",
		"message" : "check this document https://blog.abp.io/abp-7.0.2-release"	
	},
	{
		"version": "7.2.0-rc.2",
		"release-date" : "2023-02-22",
		"type" : "preview",
		"message" : "check this document https://blog.abp.io/abp-7.0.2-release"	
	}
]

@ebicoglu ebicoglu merged commit 0da9e5a into rel-7.1 Feb 23, 2023
@ebicoglu ebicoglu deleted the cli-version-check branch February 23, 2023 15:16
@rqx110
Copy link
Contributor

rqx110 commented Feb 24, 2023

Woo, this may not friendly for China users.
as I know the domain "raw.githubusercontent.com" is blocked in China

@EngincanV
Copy link
Member Author

EngincanV commented Feb 24, 2023

Woo, this may not friendly for China users. as I know the domain "raw.githubusercontent.com" is blocked in China

As far as I know, China Great Firewall has blocked GitHub and some related domains with it (also for other websites). Therefore, most of the Chinese developers use VPNs while connecting to the internet, so I think it won't create any problems for them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants