Add Dynamic Text Template infrastructure.
#16754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #16754 +/- ##
==========================================
+ Coverage 53.47% 53.48% +0.01%
==========================================
Files 2976 2981 +5
Lines 92124 92225 +101
==========================================
+ Hits 49263 49329 +66
- Misses 42861 42896 +35
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
hikalkan
approved these changes
Jun 13, 2023
|
|
||
| [NotNull] | ||
| IReadOnlyList<TemplateDefinition> GetAll(); | ||
| Task<IReadOnlyList<TemplateDefinition>> GetAllAsync(); | ||
|
|
||
| [CanBeNull] |
There was a problem hiding this comment.
Suggested change
| [CanBeNull] | |
| [ItemCanBeNull] |
| @@ -1,16 +1,17 @@ | |||
| using System.Collections.Generic; | |||
| using System.Threading.Tasks; | |||
| using JetBrains.Annotations; | |||
|
|
|||
| namespace Volo.Abp.TextTemplating; | |||
|
|
|||
| public interface ITemplateDefinitionManager | |||
| { | |||
| [NotNull] | |||
There was a problem hiding this comment.
Suggested change
| [NotNull] | |
| [ItemNotNull] |
| using JetBrains.Annotations; | ||
|
|
||
| namespace Volo.Abp.TextTemplating; | ||
|
|
||
| public interface ITemplateDefinitionManager | ||
| { | ||
| [NotNull] | ||
| TemplateDefinition Get([NotNull] string name); | ||
| Task<TemplateDefinition> GetAsync([NotNull] string name); | ||
|
|
||
| [NotNull] |
There was a problem hiding this comment.
Suggested change
| [NotNull] | |
| [ItemNotNull] |
|
I will do the changes, no problem. Can you please create a migration guide and write that change for 7.4. |
ok. |
Merged
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change:
LocalizationResource(Type)ofTemplateDefinitionclass is changed toLocalizationResourceName(string)