Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use WebApplicationFactory as the base class for Web integration testing. #17497

Merged
merged 5 commits into from
Sep 5, 2023

Conversation

maliming
Copy link
Member

Resolve #17484

@maliming maliming added this to the 8.0-preview milestone Aug 29, 2023
@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Merging #17497 (16999d6) into dev (c17c4c2) will increase coverage by 0.03%.
Report is 16 commits behind head on dev.
The diff coverage is 36.89%.

@@            Coverage Diff             @@
##              dev   #17497      +/-   ##
==========================================
+ Coverage   53.28%   53.31%   +0.03%     
==========================================
  Files        3025     3026       +1     
  Lines       94376    94385       +9     
==========================================
+ Hits        50289    50325      +36     
+ Misses      44087    44060      -27     
Files Changed Coverage Δ
...e/TestBase/AbpAspNetCoreAsyncIntegratedTestBase.cs 65.38% <ø> (ø)
...ing/AuditIntegrationServiceTestController_Tests.cs 0.00% <0.00%> (ø)
...pNetCore/Mvc/Auditing/AuditTestController_Tests.cs 0.00% <0.00%> (ø)
...Abp/AspNetCore/Mvc/Auditing/AuditTestPage_Tests.cs 0.00% <0.00%> (ø)
.../Mvc/Controllers/ReplaceBuiltInController_Tests.cs 0.00% <ø> (ø)
...g/AbpAuthorizationExceptionTestController_Tests.cs 0.00% <0.00%> (ø)
...andling/AbpAuthorizationExceptionTestPage_Tests.cs 0.00% <0.00%> (ø)
...ExceptionHandling/ExceptionTestController_Tests.cs 0.00% <0.00%> (ø)
...e/Mvc/ExceptionHandling/ExceptionTestPage_Tests.cs 0.00% <0.00%> (ø)
.../AspNetCore/Mvc/Json/JsonResultController_Tests.cs 0.00% <0.00%> (ø)
... and 14 more

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@maliming maliming changed the title Using WebApplicationFactory as web unit test base class. Use "WebApplicationFactory" as the base class for Web integration testing. Aug 29, 2023
@maliming maliming changed the title Use "WebApplicationFactory" as the base class for Web integration testing. Use WebApplicationFactory as the base class for Web integration testing. Aug 29, 2023
@maliming maliming requested a review from hikalkan August 29, 2023 08:48
@hikalkan hikalkan merged commit 9eb354b into dev Sep 5, 2023
4 of 5 checks passed
@hikalkan hikalkan deleted the WebApplicationFactory branch September 5, 2023 06:49
@hikalkan
Copy link
Member

hikalkan commented Sep 5, 2023

I marked as breaking change since we made obsolete the old class and we may remove it in the future. So, we should mention that in the migration guide for 8.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revisit ASP.NET Core Integration Test Infrastructure
2 participants