Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AddMarginBottomClass to remove the mb class. #17960

Merged
merged 1 commit into from Oct 30, 2023
Merged

Conversation

maliming
Copy link
Member

Resolve #17948

@maliming maliming added this to the 8.0-preview milestone Oct 24, 2023
@maliming maliming marked this pull request as ready for review October 30, 2023 03:30
@myesn
Copy link

myesn commented Oct 30, 2023

Please consider default to false, because I don't think a hidden element should have side effects:

public bool AddMarginBottomClass  { get; set; } = false;

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Merging #17960 (5381c9e) into dev (8a26da9) will decrease coverage by 0.03%.
Report is 53 commits behind head on dev.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev   #17960      +/-   ##
==========================================
- Coverage   51.66%   51.63%   -0.03%     
==========================================
  Files        3052     3054       +2     
  Lines       95431    95566     +135     
  Branches     7609     7617       +8     
==========================================
+ Hits        49306    49350      +44     
- Misses      44610    44697      +87     
- Partials     1515     1519       +4     

see 8 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@maliming
Copy link
Member Author

Please consider default to false, because I don't think a hidden element should have side effects:

public bool AddMarginBottomClass  { get; set; } = false;

We don't want to make a breaking change.

@EngincanV EngincanV merged commit 7ae5123 into dev Oct 30, 2023
5 of 6 checks passed
@EngincanV EngincanV deleted the AddMarginBottomClass branch October 30, 2023 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove mb-3 that surrounds abp-input mvc tag helper
3 participants