Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve bundle file #18131

Merged
merged 2 commits into from Nov 13, 2023
Merged

improve bundle file #18131

merged 2 commits into from Nov 13, 2023

Conversation

salihozkara
Copy link
Member

Description

There were issues with the AddIfNotContains method, so I inherited from IEquatable to address them. Similarly, to ensure no issues with the ReplaceOne method, I inherited from IComparable.

Checklist

  • I fully tested it as developer / designer and created unit / integration tests
  • I documented it (or no need to document or I will create a separate documentation issue)

How to test it?

Please describe how this can be tested by the test engineers if it is not already explicit - or remove this section if no need to description.

Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Merging #18131 (5d0dc70) into dev (2726d57) will decrease coverage by 0.02%.
Report is 17 commits behind head on dev.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##              dev   #18131      +/-   ##
==========================================
- Coverage   51.65%   51.64%   -0.02%     
==========================================
  Files        3058     3058              
  Lines       95810    95843      +33     
  Branches     7637     7644       +7     
==========================================
  Hits        49494    49494              
- Misses      44797    44830      +33     
  Partials     1519     1519              
Files Coverage Δ
.../Volo/Abp/AspNetCore/Mvc/UI/Bundling/BundleFile.cs 0.00% <0.00%> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@maliming maliming removed this from the 8.0-preview milestone Nov 13, 2023
@maliming maliming closed this Nov 13, 2023
@maliming maliming reopened this Nov 13, 2023
@maliming maliming added this to the 8.0-preview milestone Nov 13, 2023
@maliming maliming merged commit b128006 into dev Nov 13, 2023
3 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants