Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CLI to create app-nolayers template #18295

Merged
merged 5 commits into from Nov 29, 2023
Merged

Conversation

realLiangshiwei
Copy link
Member

Description

Resolves https://github.com/volosoft/volo/issues/15826

Checklist

  • I fully tested it as developer / designer and created unit / integration tests
  • I documented it (or no need to document or I will create a separate documentation issue)

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (71bba01) 51.64% compared to head (c8aa100) 51.64%.
Report is 2 commits behind head on rel-8.0.

❗ Current head c8aa100 differs from pull request most recent head 7fe189d. Consider uploading reports for the commit 7fe189d to get more accurate results

Files Patch % Lines
...ttingsFilePortChangeForSeparatedAuthServersStep.cs 0.00% 3 Missing ⚠️
...ctBuilding/Templates/RemoveUnnecessaryPortsStep.cs 0.00% 3 Missing ⚠️
...tBuilding/Templates/App/AppNoLayersTemplateBase.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           rel-8.0   #18295      +/-   ##
===========================================
- Coverage    51.64%   51.64%   -0.01%     
===========================================
  Files         3073     3073              
  Lines        96638    96644       +6     
  Branches      7682     7684       +2     
===========================================
  Hits         49909    49909              
- Misses       45200    45206       +6     
  Partials      1529     1529              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maliming maliming merged commit 3e15201 into rel-8.0 Nov 29, 2023
3 checks passed
@maliming maliming deleted the liangshiwei/cli-patch branch November 29, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants