Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better PageHeader rendering for Settings [8.0] #18299

Merged
merged 1 commit into from Nov 30, 2023

Conversation

enisn
Copy link
Member

@enisn enisn commented Nov 29, 2023

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (0a248f7) 51.63% compared to head (cf19b6a) 51.68%.
Report is 58 commits behind head on rel-8.0.

Files Patch % Lines
...TemplateChangeConsoleTestClientPortSettingsStep.cs 0.00% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           rel-8.0   #18299      +/-   ##
===========================================
+ Coverage    51.63%   51.68%   +0.04%     
===========================================
  Files         3070     3073       +3     
  Lines        96541    96923     +382     
  Branches      7672     7751      +79     
===========================================
+ Hits         49849    50092     +243     
- Misses       45164    45296     +132     
- Partials      1528     1535       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@realLiangshiwei realLiangshiwei added this to the 8.0-final milestone Nov 30, 2023
@gizemmutukurt gizemmutukurt requested review from gizemmutukurt and removed request for oykuermann November 30, 2023 13:34
@gizemmutukurt gizemmutukurt merged commit 0800e63 into rel-8.0 Nov 30, 2023
8 of 9 checks passed
@gizemmutukurt gizemmutukurt deleted the 8.0-prevent-stackoverflow-blazor branch November 30, 2023 13:40
@gizemmutukurt gizemmutukurt restored the 8.0-prevent-stackoverflow-blazor branch November 30, 2023 13:40
@gizemmutukurt gizemmutukurt deleted the 8.0-prevent-stackoverflow-blazor branch November 30, 2023 13:40
@enisn enisn restored the 8.0-prevent-stackoverflow-blazor branch December 7, 2023 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants