Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NormalizedName property to Tenant. #18426

Merged
merged 8 commits into from Jan 24, 2024
Merged

Add NormalizedName property to Tenant. #18426

merged 8 commits into from Jan 24, 2024

Conversation

maliming
Copy link
Member

@maliming maliming commented Dec 11, 2023

Resolve #18394

The ITenantStore will use the normalizedName parameter to get tenants, We need to use ITenantNormalizer to normalize tenant names.

@maliming maliming marked this pull request as ready for review December 31, 2023 10:40
Copy link

codecov bot commented Dec 31, 2023

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (52a4eda) 51.60% compared to head (5438d7c) 51.61%.

Files Patch % Lines
...ancy/Pages/Abp/MultiTenancy/AbpTenantAppService.cs 0.00% 6 Missing ⚠️
...Pages/Abp/MultiTenancy/TenantSwitchModal.cshtml.cs 0.00% 4 Missing ⚠️
...nt.Domain/Volo/Abp/TenantManagement/TenantStore.cs 63.63% 2 Missing and 2 partials ⚠️
...AspNetCore/Mvc/MultiTenancy/FindTenantResultDto.cs 0.00% 1 Missing ⚠️
...Abp/MultiTenancy/UpperInvariantTenantNormalizer.cs 66.66% 0 Missing and 1 partial ⚠️
...tiTenancy/ConfigurationStore/DefaultTenantStore.cs 50.00% 0 Missing and 1 partial ⚠️
.../TenantManagement/MongoDb/MongoTenantRepository.cs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #18426      +/-   ##
==========================================
+ Coverage   51.60%   51.61%   +0.01%     
==========================================
  Files        3078     3079       +1     
  Lines       97480    97514      +34     
  Branches     7774     7775       +1     
==========================================
+ Hits        50302    50333      +31     
- Misses      45629    45632       +3     
  Partials     1549     1549              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hikalkan hikalkan merged commit 146787f into dev Jan 24, 2024
5 checks passed
@hikalkan hikalkan deleted the NormalizedName branch January 24, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add NormalizedTenantName to Tenant entity.
2 participants