Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use IsNullOrEmpty instead null-check in AuditLogs Repositories #18504

Merged
merged 1 commit into from Dec 18, 2023

Conversation

enisn
Copy link
Member

@enisn enisn commented Dec 18, 2023

Description

Resolves https://github.com/volosoft/volo/issues/15999

Since empty values are considered as filtering options for strings, Audit logs repositories will check if it's NullOrEmpty, instead only null-check.

⚠️ Breaking Change Note

Warning: This may cause some behavioral changes if you used this repository methods by your own

Checklist

  • I fully tested it as developer / designer and created unit / integration tests
  • I documented it (or no need to document or I will create a separate documentation issue)

How to test it?

Please describe how this can be tested by the test engineers if it is not already explicit - or remove this section if no need to description.

Copy link

codecov bot commented Dec 18, 2023

Codecov Report

Attention: 42 lines in your changes are missing coverage. Please review.

Comparison is base (b049d07) 51.58% compared to head (c079cdc) 51.58%.
Report is 22 commits behind head on rel-8.0.

Files Patch % Lines
...dict/Applications/AbpOpenIddictApplicationStore.cs 55.35% 23 Missing and 2 partials ⚠️
...enIddict/Tokens/EfCoreOpenIddictTokenRepository.cs 14.28% 6 Missing ⚠️
...penIddict/Tokens/MongoOpenIddictTokenRepository.cs 25.00% 6 Missing ⚠️
...o/Abp/OpenIddict/Tokens/AbpOpenIddictTokenStore.cs 40.00% 3 Missing ⚠️
...ng/Building/TemplateProjectBuildPipelineBuilder.cs 0.00% 1 Missing ⚠️
...ct/Applications/OpenIddictApplicationExtensions.cs 92.30% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           rel-8.0   #18504   +/-   ##
========================================
  Coverage    51.58%   51.58%           
========================================
  Files         3073     3073           
  Lines        96910    96910           
  Branches      7715     7715           
========================================
  Hits         49987    49987           
  Misses       45392    45392           
  Partials      1531     1531           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gizemmutukurt gizemmutukurt requested review from gizemmutukurt and removed request for oykuermann December 18, 2023 08:36
@ebicoglu ebicoglu merged commit 696b984 into rel-8.0 Dec 18, 2023
5 checks passed
@ebicoglu ebicoglu deleted the 8.0-auditlogs-empty-filter branch December 18, 2023 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants