Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IMultiTenantUrlProvider #18592

Merged
merged 2 commits into from
Dec 30, 2023
Merged

Add IMultiTenantUrlProvider #18592

merged 2 commits into from
Dec 30, 2023

Conversation

realLiangshiwei
Copy link
Member

@realLiangshiwei realLiangshiwei commented Dec 26, 2023

Description

Resolves #18545

Checklist

  • I fully tested it as developer / designer and created unit / integration tests
  • I documented it (or no need to document or I will create a separate documentation issue)

How to test it?

Configure<AbpTenantResolveOptions>(options =>
{
    options.AddDomainTenantResolver("{0}.mydomain.com");
});
{
  "RemoteServices": {
    "Default": {
      "BaseUrl": "http://{{tenantName}}.mydomain.com/"
    }
  } 
}

@realLiangshiwei realLiangshiwei changed the base branch from dev to rel-8.0 December 26, 2023 07:17
@realLiangshiwei realLiangshiwei added this to the 8.0-patch milestone Dec 26, 2023
Copy link

codecov bot commented Dec 26, 2023

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (931232d) 51.58% compared to head (b9a6bff) 51.61%.
Report is 49 commits behind head on rel-8.0.

Files Patch % Lines
.../Http/Client/RemoteServiceConfigurationProvider.cs 83.33% 3 Missing and 1 partial ⚠️
...ding/Building/Steps/ProjectReferenceReplaceStep.cs 0.00% 3 Missing ⚠️
...viceProxying/CSharp/CSharpServiceProxyGenerator.cs 0.00% 1 Missing ⚠️
...cy/Volo/Abp/MultiTenancy/MultiTenantUrlProvider.cs 97.72% 0 Missing and 1 partial ⚠️
...tion/Volo/Abp/Ui/Navigation/Urls/AppUrlProvider.cs 80.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           rel-8.0   #18592      +/-   ##
===========================================
+ Coverage    51.58%   51.61%   +0.03%     
===========================================
  Files         3073     3074       +1     
  Lines        96926    96942      +16     
  Branches      7716     7712       -4     
===========================================
+ Hits         50001    50040      +39     
+ Misses       45394    45370      -24     
- Partials      1531     1532       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hikalkan hikalkan merged commit 357d802 into rel-8.0 Dec 30, 2023
5 checks passed
@hikalkan hikalkan deleted the liangshiwei/cli branch December 30, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

C# client proxy should be compatible with subdomain multi-tenancy
3 participants