Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output warning if the CLI version is different from the template version. #18629

Merged
merged 1 commit into from Dec 29, 2023

Conversation

maliming
Copy link
Member

Resolve #18624

@maliming maliming added this to the 8.1-preview milestone Dec 29, 2023
@maliming maliming changed the base branch from rel-8.0 to dev December 29, 2023 03:40
Copy link

codecov bot commented Dec 29, 2023

Codecov Report

Attention: 72 lines in your changes are missing coverage. Please review.

Comparison is base (21e70fd) 51.74% compared to head (ce0e1d4) 51.57%.
Report is 33 commits behind head on dev.

Files Patch % Lines
...lo/Abp/Cli/ProjectBuilding/AbpIoSourceCodeStore.cs 5.66% 50 Missing ⚠️
...Cli.Core/Volo/Abp/Cli/Version/CliVersionService.cs 18.18% 18 Missing ⚠️
...k/src/Volo.Abp.Cli.Core/Volo/Abp/Cli/CliService.cs 60.00% 2 Missing ⚠️
...ceProxying/Angular/AngularServiceProxyGenerator.cs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #18629      +/-   ##
==========================================
- Coverage   51.74%   51.57%   -0.17%     
==========================================
  Files        3075     3074       -1     
  Lines       96947    96961      +14     
  Branches     7715     7720       +5     
==========================================
- Hits        50161    50010     -151     
- Misses      45251    45420     +169     
+ Partials     1535     1531       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EngincanV EngincanV merged commit fd86913 into dev Dec 29, 2023
3 of 5 checks passed
@EngincanV EngincanV deleted the cli-version-warning branch December 29, 2023 11:46
@ebicoglu ebicoglu changed the title Output warning if the cli version is different from the template version. Output warning if the CLI version is different from the template version. Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI: Create project with the CLI version
2 participants