Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Live Demo register page description alignment. #18633

Merged
merged 6 commits into from Jan 4, 2024
Merged

Conversation

denizdemirkan
Copy link
Contributor

Resolves https://github.com/volosoft/vs-internal/issues/3434

This branch improving UI alignment in Live Demo register page.

new
new2

@gizemmutukurt
Copy link
Contributor

I am getting related errors while testing

image

@@ -37,7 +37,7 @@
"StartUsingYourLicenseNow": "¡Empiece a usar su licencia ahora!",
"WelcomePage": "Pagina de bienvenida",
"UnsubscriptionExpireEmail": "Cancelar la suscripción a los correos electrónicos de recordatorio de la fecha de vencimiento de la licencia",
"UnsubscribeLicenseExpireEmailReminderMessage": "Esta suscripción de correo electrónico solo contiene un recordatorio de la fecha de vencimiento de su licencia.",
"UnsubscribeLicenseExpireEmailReminderMessage": "Esta suscripción de correo electrónico solo contiene un recordatorio de la fcha de vencimiento de su licencia.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert this line

@gizemmutukurt gizemmutukurt requested review from oykuermann and removed request for gizemmutukurt January 2, 2024 14:01
@oykuermann
Copy link
Contributor

I got errors when trying to run Account.Web project:
image

@denizdemirkan
Copy link
Contributor Author

denizdemirkan commented Jan 3, 2024

Fixed #18633 (comment)

@oykuermann
To test this issue
1 - change branch on abp repository to issue-3434 (others must be on dev branch)
2 - Run Account app
3 - Run Commercial app
4 - Sign-out if you are logged in
5 - Go to Live Demo page at commercial domain.

@gizemmutukurt gizemmutukurt requested review from gizemmutukurt and removed request for oykuermann January 4, 2024 05:02
@gizemmutukurt
Copy link
Contributor

gizemmutukurt commented Jan 4, 2024

You do not need an Account app to go to this page. Running Commercial is enough.

@gizemmutukurt gizemmutukurt merged commit 74e27a0 into dev Jan 4, 2024
2 checks passed
@gizemmutukurt gizemmutukurt deleted the issue-#3434 branch January 4, 2024 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants