Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ClaimNameExist to IdentityErrorCodes #18669

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

realLiangshiwei
Copy link
Member

@realLiangshiwei realLiangshiwei commented Jan 3, 2024

Description

Related: https://github.com/volosoft/volo/issues/16169

Checklist

  • I fully tested it as developer / designer and created unit / integration tests
  • I documented it (or no need to document or I will create a separate documentation issue)

How to test it?

Copy link

codecov bot commented Jan 3, 2024

Codecov Report

Attention: 39 lines in your changes are missing coverage. Please review.

Comparison is base (3a23269) 51.60% compared to head (c4a0b46) 51.59%.
Report is 13 commits behind head on rel-8.0.

Files Patch % Lines
...olo/Abp/Cli/Commands/ProjectCreationCommandBase.cs 0.00% 20 Missing ⚠️
...ectModification/VoloNugetPackagesVersionUpdater.cs 0.00% 16 Missing ⚠️
...bp.Cli.Core/Volo/Abp/Cli/Commands/UpdateCommand.cs 0.00% 2 Missing ⚠️
...olo/Abp/Identity/IdentityClaimTypeManager_Tests.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           rel-8.0   #18669      +/-   ##
===========================================
- Coverage    51.60%   51.59%   -0.02%     
===========================================
  Files         3074     3074              
  Lines        97091    97110      +19     
  Branches      7729     7732       +3     
===========================================
  Hits         50106    50106              
- Misses       45444    45463      +19     
  Partials      1541     1541              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maliming maliming merged commit 7399b99 into rel-8.0 Jan 3, 2024
3 of 5 checks passed
@maliming maliming deleted the liangshiwei/identityclaims branch January 3, 2024 03:05
@gizemmutukurt
Copy link
Contributor

Please add @oykuermann and me for functional testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants