Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an empty view for blog posts #18780

Merged
merged 1 commit into from Jan 23, 2024
Merged

Add an empty view for blog posts #18780

merged 1 commit into from Jan 23, 2024

Conversation

enisn
Copy link
Member

@enisn enisn commented Jan 17, 2024

Description

Resolves #18765

Part of https://github.com/volosoft/vs-internal/issues/3588

When there is no blog post in the blog index, the following message will be rendered:
image

image

Checklist

  • I fully tested it as developer / designer and created unit / integration tests
  • I documented it (or no need to document or I will create a separate documentation issue)

How to test it?

Please describe how this can be tested by the test engineers if it is not already explicit - or remove this section if no need to description.

Copy link

codecov bot commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (211599f) 51.57% compared to head (ed3ada8) 51.59%.
Report is 14 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #18780      +/-   ##
==========================================
+ Coverage   51.57%   51.59%   +0.02%     
==========================================
  Files        3079     3079              
  Lines       97579    97658      +79     
  Branches     7788     7792       +4     
==========================================
+ Hits        50327    50391      +64     
- Misses      45705    45720      +15     
  Partials     1547     1547              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oykuermann oykuermann added this to the 8.1-preview milestone Jan 23, 2024
@oykuermann oykuermann merged commit a618cd2 into dev Jan 23, 2024
5 checks passed
@oykuermann oykuermann deleted the cmskit-blogposts-index branch January 23, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CMS Kit - Add empty page for blog index
2 participants