CMSKit - MenuItem & Page relation enhancements #18782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enisn
changed the title
enisn
changed the title
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #18782 +/- ##
==========================================
+ Coverage 51.59% 51.63% +0.04%
==========================================
Files 3082 3084 +2
Lines 97721 97837 +116
Branches 7800 7807 +7
==========================================
+ Hits 50416 50523 +107
- Misses 45755 45761 +6
- Partials 1550 1553 +3 ☔ View full report in Codecov by Sentry. |
|
Tests are passing now, There is rate-limiting problem in the pipeline |
oykuermann
requested changes
Jan 22, 2024
There was a problem hiding this comment.
I'll check after the changes: https://github.com/volosoft/volo/pull/16457#issuecomment-1903945541
oykuermann
approved these changes
Jan 23, 2024
|
I'm waiting for @realLiangshiwei 's review to merge this PR. |
| @@ -76,4 +76,10 @@ public virtual Task<List<Page>> GetListOfHomePagesAsync(CancellationToken cancel | |||
| { | |||
| return GetListAsync(x => x.IsHomePage, cancellationToken: GetCancellationToken(cancellationToken)); | |||
| } | |||
|
|
|||
| public async Task<string> FindTitleAsync(Guid pageId, CancellationToken cancellationToken = default) | |||
realLiangshiwei
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of https://github.com/volosoft/vs-internal/issues/3588
With this PR, MenuItem and Page have a better relationship.
Required fields:
When a page is selected:
Checklist
How to test it?
Please describe how this can be tested by the test engineers if it is not already explicit - or remove this section if no need to description.