Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if the type is a component before rendering #18783

Merged
merged 1 commit into from Jan 18, 2024
Merged

Conversation

realLiangshiwei
Copy link
Member

Description

Related: https://github.com/volosoft/volo/issues/16417

Checklist

  • I fully tested it as developer / designer and created unit / integration tests
  • I documented it (or no need to document or I will create a separate documentation issue)

@realLiangshiwei realLiangshiwei added this to the 8.1-preview milestone Jan 17, 2024
Copy link

codecov bot commented Jan 17, 2024

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Comparison is base (643315a) 51.57% compared to head (75598e7) 51.59%.
Report is 3 commits behind head on dev.

Files Patch % Lines
...e/TestBase/AbpAspNetCoreAsyncIntegratedTestBase.cs 0.00% 6 Missing ⚠️
...TestBase/AbpWebApplicationFactoryIntegratedTest.cs 0.00% 6 Missing ⚠️
...asic/Themes/Basic/Components/Menu/_MenuItem.cshtml 0.00% 4 Missing ⚠️
...estBase/Volo/Abp/AbpTestBaseWithServiceProvider.cs 50.00% 3 Missing ⚠️
....Basic/Themes/Basic/Components/Menu/Default.cshtml 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #18783      +/-   ##
==========================================
+ Coverage   51.57%   51.59%   +0.02%     
==========================================
  Files        3079     3079              
  Lines       97579    97658      +79     
  Branches     7788     7792       +4     
==========================================
+ Hits        50327    50390      +63     
- Misses      45705    45720      +15     
- Partials     1547     1548       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@enisn enisn merged commit 468715c into dev Jan 18, 2024
5 checks passed
@enisn enisn deleted the liangshiwei/customMenu branch January 18, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants