Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ValueProvider system. #18823

Merged
merged 5 commits into from Jan 29, 2024
Merged

Improve ValueProvider system. #18823

merged 5 commits into from Jan 29, 2024

Conversation

realLiangshiwei
Copy link
Member

Description

Resolves #18808 #18809

Checklist

  • I fully tested it as developer / designer and created unit / integration tests
  • I documented it (or no need to document or I will create a separate documentation issue)

How to test it?

Copy link

codecov bot commented Jan 22, 2024

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (e18c384) 51.59% compared to head (8d9e3e0) 51.67%.
Report is 152 commits behind head on dev.

Files Patch % Lines
...bp/PermissionManagement/PermissionManager_Tests.cs 0.00% 11 Missing ⚠️
...Volo/Abp/FeatureManagement/FeatureManager_Tests.cs 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #18823      +/-   ##
==========================================
+ Coverage   51.59%   51.67%   +0.08%     
==========================================
  Files        3082     3092      +10     
  Lines       97721    98028     +307     
  Branches     7800     7817      +17     
==========================================
+ Hits        50416    50659     +243     
- Misses      45755    45818      +63     
- Partials     1550     1551       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maliming maliming marked this pull request as draft January 26, 2024 02:01
@realLiangshiwei realLiangshiwei marked this pull request as ready for review January 26, 2024 02:05
@maliming maliming changed the title Improve setting system Improve ValueProvider system. Jan 29, 2024
@maliming maliming merged commit fee3a93 into dev Jan 29, 2024
5 checks passed
@maliming maliming deleted the liangshiwei/settings branch January 29, 2024 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SettingManager will do nothing if we call SetAsync with an undefined provider
2 participants