Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use outline button variation in modals #18842

Merged
merged 11 commits into from Jan 25, 2024
Merged

Use outline button variation in modals #18842

merged 11 commits into from Jan 25, 2024

Conversation

enisn
Copy link
Member

@enisn enisn commented Jan 23, 2024

Description

Part of https://github.com/volosoft/volo/issues/16449

abp modal buttons

abp modal buttons

Checklist

  • I fully tested it as developer / designer and created unit / integration tests
  • I documented it (or no need to document or I will create a separate documentation issue)

How to test it?

Please describe how this can be tested by the test engineers if it is not already explicit - or remove this section if no need to description.

@enisn enisn marked this pull request as ready for review January 24, 2024 12:28
Copy link

codecov bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4fac3a8) 51.65% compared to head (4384eb6) 51.65%.
Report is 16 commits behind head on dev.

❗ Current head 4384eb6 differs from pull request most recent head 46afb5e. Consider uploading reports for the commit 46afb5e to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##              dev   #18842   +/-   ##
=======================================
  Coverage   51.65%   51.65%           
=======================================
  Files        3084     3084           
  Lines       97841    97841           
  Branches     7808     7808           
=======================================
  Hits        50537    50537           
  Misses      45751    45751           
  Partials     1553     1553           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@realLiangshiwei
Copy link
Member

<Button style="margin: 0.25rem" Outline Color="Color.Primary" Clicked="OpenSendTestEmailModalAsync">@L["SendTestEmail"]</Button>

<Button style="margin: 0.25rem" Color="Color.Primary" Clicked="OpenSendTestEmailModalAsync">@L["SendTestEmail"]</Button>

@realLiangshiwei realLiangshiwei merged commit 0ee3c58 into dev Jan 25, 2024
3 checks passed
@realLiangshiwei realLiangshiwei deleted the ux-enhancements branch January 25, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants