Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace theme package in package.json #18978

Merged
merged 2 commits into from Feb 9, 2024
Merged

Conversation

maliming
Copy link
Member

@maliming maliming commented Feb 9, 2024

Resolve #18968

@maliming maliming added this to the 8.0-patch milestone Feb 9, 2024
@EngincanV EngincanV changed the title Repalce theme package in package.json Replace theme package in package.json Feb 9, 2024
Copy link

codecov bot commented Feb 9, 2024

Codecov Report

Attention: 144 lines in your changes are missing coverage. Please review.

Comparison is base (8b6c8d5) 51.57% compared to head (8fa04cb) 51.53%.
Report is 1 commits behind head on rel-8.0.

❗ Current head 8fa04cb differs from pull request most recent head d42e810. Consider uploading reports for the commit d42e810 to get more accurate results

Files Patch % Lines
...tBuilding/Templates/App/AppNoLayersTemplateBase.cs 0.00% 37 Missing ⚠️
...i/ProjectBuilding/Templates/App/AppTemplateBase.cs 0.00% 37 Missing ⚠️
...Templates/Microservice/MicroserviceTemplateBase.cs 0.00% 37 Missing ⚠️
.../Steps/ReplaceDependencyFromPackageJsonFileStep.cs 0.00% 33 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           rel-8.0   #18978      +/-   ##
===========================================
- Coverage    51.57%   51.53%   -0.04%     
===========================================
  Files         3077     3078       +1     
  Lines        97330    97414      +84     
  Branches      7754     7776      +22     
===========================================
+ Hits         50200    50205       +5     
- Misses       45584    45663      +79     
  Partials      1546     1546              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EngincanV EngincanV self-requested a review February 9, 2024 08:15
Copy link
Member

@EngincanV EngincanV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we don't specify the version, it will be null and in that case, only the package name will be changed, not the version. For example, if I select basic theme, the CLI won't change the version and it will stay as 3.1.0.

Can you please cover this scenerio? @maliming

@maliming
Copy link
Member Author

maliming commented Feb 9, 2024

ok, I will test this case. Thanks.

@EngincanV EngincanV merged commit 4cbdd84 into rel-8.0 Feb 9, 2024
3 checks passed
@EngincanV EngincanV deleted the ReplaceLeptonXThemePackages branch February 9, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants