Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INVALID] CMS: Dummy placeholders should be stored as embedded resources. #19172

Closed
wants to merge 3 commits into from

Conversation

EngincanV
Copy link
Member

No description provided.

@EngincanV EngincanV added this to the 8.1-final milestone Feb 29, 2024
@EngincanV EngincanV requested a review from enisn February 29, 2024 14:27
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ EngincanV
❌ github-actions[bot]
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.61%. Comparing base (8731deb) to head (c2c68c9).
Report is 47 commits behind head on rel-8.1.

❗ Current head c2c68c9 differs from pull request most recent head e6e3ce4. Consider uploading reports for the commit e6e3ce4 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           rel-8.1   #19172   +/-   ##
========================================
  Coverage    51.61%   51.61%           
========================================
  Files         3095     3095           
  Lines        98183    98188    +5     
  Branches      7850     7849    -1     
========================================
+ Hits         50677    50681    +4     
- Misses       45948    45952    +4     
+ Partials      1558     1555    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EngincanV
Copy link
Member Author

Moved to #19173

@EngincanV EngincanV closed this Feb 29, 2024
@EngincanV EngincanV removed the request for review from enisn February 29, 2024 15:12
@EngincanV EngincanV removed this from the 8.1-final milestone Feb 29, 2024
@EngincanV EngincanV changed the title CMS: Dummy placeholders should be stored as embedded resources. [INVALID] CMS: Dummy placeholders should be stored as embedded resources. Feb 29, 2024
@realLiangshiwei realLiangshiwei deleted the cms-dummy-image branch March 1, 2024 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants