Blazor Page Title #19279
Merged
Blazor Page Title #19279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## rel-8.1 #19279 +/- ##
========================================
Coverage 51.61% 51.61%
========================================
Files 3095 3095
Lines 98209 98209
Branches 7851 7851
========================================
+ Hits 50687 50689 +2
+ Misses 45966 45965 -1
+ Partials 1556 1555 -1 ☔ View full report in Codecov by Sentry. |
| @@ -2,6 +2,9 @@ | |||
| @using Volo.Abp.MultiTenancy | |||
| @inherits MyProjectNameComponentBase | |||
| @inject AuthenticationStateProvider AuthenticationStateProvider | |||
|
|
|||
| <PageTitle>Index</PageTitle> | |||
There was a problem hiding this comment.
Should consider localization
realLiangshiwei
approved these changes
Mar 13, 2024
|
It's formatted like MVC: |
oykuermann
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enables controlling head section by using HeadOutlet of Blazor.
(https://learn.microsoft.com/en-us/aspnet/core/blazor/components/control-head-content?view=aspnetcore-8.0)
PageHeader implements PageTitle by default. So no need further actions to show page titles. Existing modules and pages that use PageHeader will automatically update page title.
Resolves https://github.com/volosoft/volo/issues/16482#issuecomment-1963412039
Checklist
How to test it?
Please describe how this can be tested by the test engineers if it is not already explicit - or remove this section if no need to description.