Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recursively check if the ValueObject are ValueEquals. #19313

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Conversation

maliming
Copy link
Member

Resolve #19312

@maliming maliming added this to the 8.2-preview milestone Mar 15, 2024
@maliming maliming requested a review from EngincanV March 15, 2024 09:15
Copy link

codecov bot commented Mar 15, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 51.56%. Comparing base (a34c217) to head (ec43e96).
Report is 6 commits behind head on dev.

Files Patch % Lines
...p.Ddd.Domain/Volo/Abp/Domain/Values/ValueObject.cs 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev   #19313   +/-   ##
=======================================
  Coverage   51.56%   51.56%           
=======================================
  Files        3098     3098           
  Lines       98526    98532    +6     
  Branches     7875     7877    +2     
=======================================
+ Hits        50804    50810    +6     
  Misses      46157    46157           
  Partials     1565     1565           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EngincanV EngincanV merged commit 9bbad61 into dev Mar 15, 2024
5 checks passed
@EngincanV EngincanV deleted the ValueObject branch March 15, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ValueEquals doesn't recursively apply to the atomic values
2 participants