Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding toastr notifications with new "SuccessfullySaved" localization #19326

Merged
merged 8 commits into from
Mar 26, 2024
Merged

Adding toastr notifications with new "SuccessfullySaved" localization #19326

merged 8 commits into from
Mar 26, 2024

Conversation

yusuf-cirak
Copy link
Contributor

@yusuf-cirak yusuf-cirak commented Mar 15, 2024 •
edited
Loading

Description

Resolves #19324

  • Adding localization messages.
  • Adding toast messages to operations in feature-management, identity, tenant-management modules.

Checklist

  • I fully tested it as developer

How to test it?

  • Perform some create or update operations.

@yusuf-cirak
enhancement(framework): Adding "SuccessfullySaved" localization messa…
0f123ea 
…ges to Volo.Abp.UI
@yusuf-cirak
enhancement(npm/ng-packs): Adding toaster notifications to account, f…
771675d 
…eature management, identity, permission management, tenant management create, update, delete operations
@yusuf-cirak yusuf-cirak added abp-framework ui-angular localization module & application template localizations labels Mar 15, 2024
@yusuf-cirak yusuf-cirak added this to the 8.2-preview milestone Mar 15, 2024
@CLAassistant
Copy link

CLAassistant commented Mar 15, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@gizemmutukurt gizemmutukurt requested review from oykuermann and gizemmutukurt and removed request for gizemmutukurt and oykuermann March 18, 2024 04:19
oykuermann
oykuermann requested changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@oykuermann oykuermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Localization names should be 'SavedSuccesfully' and 'DeletedSuccesfully'. Please, rewrite all the localizations.
image

@yusuf-cirak
Copy link
Contributor Author

Localization names should be 'SavedSuccesfully' and 'DeletedSuccesfully'. Please, rewrite all the localizations. image

I'm not sure about this. Other UI's will need to change their localizations too. If that's okay, i can change all.

@gizemmutukurt
Copy link
Contributor

This is how the majority approved it on the channel @yusuf-cirak

image

@oykuermann oykuermann changed the title Adding toaster notifications with new "SuccessfullySaved" localization Adding toastr notifications with new "SuccessfullySaved" localization Mar 19, 2024
@oykuermann oykuermann merged commit 8029add into dev Mar 26, 2024
2 of 3 checks passed
@oykuermann oykuermann deleted the issue-19324 branch March 26, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masumulu28 masumulu28 masumulu28 approved these changes

@oykuermann oykuermann oykuermann approved these changes

Assignees
No one assigned
Labels
abp-framework localization module & application template localizations ui-angular
Projects
None yet
Milestone
8.2-preview
Development

Successfully merging this pull request may close these issues.

Toaster should display after create, update, delete operations
6 participants
@yusuf-cirak @CLAassistant @gizemmutukurt @masumulu28 @oykuermann @denizdemirkan