Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update route path to kebab-case while adding module or source code #19349

Merged
merged 1 commit into from Mar 21, 2024

Conversation

Sinan997
Copy link
Member

In angular we are using kebab-case for route paths.
So i have changed to ToKebabCase() instead of ToLower().

Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 51.64%. Comparing base (3ea7f9a) to head (46223d4).
Report is 36 commits behind head on rel-8.1.

Files Patch % Lines
.../Cli/ProjectModification/AngularSourceCodeAdder.cs 0.00% 1 Missing ⚠️
...Abp/Cli/ProjectModification/SolutionModuleAdder.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           rel-8.1   #19349   +/-   ##
========================================
  Coverage    51.63%   51.64%           
========================================
  Files         3096     3096           
  Lines        98231    98231           
  Branches      7853     7853           
========================================
+ Hits         50726    50732    +6     
+ Misses       45948    45943    -5     
+ Partials      1557     1556    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@masumulu28
Copy link
Member

Have you test it with a creating new project ? Can you add some output as image please ?

@masumulu28 masumulu28 merged commit 2f1142f into rel-8.1 Mar 21, 2024
4 of 5 checks passed
@masumulu28 masumulu28 deleted the sinan/module-path branch March 21, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants