Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMS Kit: Approvement system for the comments #19919

Merged
merged 54 commits into from
Jun 13, 2024
Merged

Conversation

EmreKendirli
Copy link
Contributor

Resolves #17772

@EmreKendirli EmreKendirli marked this pull request as ready for review May 24, 2024 14:30
@berkansasmaz berkansasmaz marked this pull request as ready for review June 4, 2024 08:22
Copy link
Contributor

@gizemmutukurt gizemmutukurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Comments that were previously visible on the screen should not disappear. The solution to this may be this: When a new comment arrives, if the approval system is turned off, this new comment is recorded as directly approved (IsApproved = true). If the confirmation system is on, it is recorded as null. Thus, if it is activated later, previous comments will be considered approved.
    If the approval system is turned off, automatic approval will occur.

image

image

@EngincanV
Copy link
Member

When the setting is activated, old unapproved comments will not appear. For this situation, it would be good to show a warning in a modal while activating

image

Instead of doing this, I think we should also save the date when it's enabled, and start approvement from that day. It's not practical to hide all already seen comments, after enabling the comment approvement setting.

@berkansasmaz
Copy link
Member

When the setting is activated, old unapproved comments will not appear. For this situation, it would be good to show a warning in a modal while activating
image

Instead of doing this, I think we should also save the date when it's enabled, and start approvement from that day. It's not practical to hide all already seen comments, after enabling the comment approvement setting.

For now, we are showing a warning when enabling settings. But we will take your feedback into consideration, if it is considered appropriate I will update it as you said, thanks @EngincanV 🙏

@gizemmutukurt gizemmutukurt self-requested a review June 5, 2024 12:09
Copy link
Contributor

@gizemmutukurt gizemmutukurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I click on comments awaiting approval, the page does not load

Apex_1717751198153.webm

@gizemmutukurt gizemmutukurt self-requested a review June 7, 2024 10:32
@gizemmutukurt
Copy link
Contributor

It would be better to put the Approve State column before the creation date, it is not very eye-catching at the end and creation times are generally placed at the end in systems.

image

@enisn
Copy link
Member

enisn commented Jun 13, 2024

The button texts colors is wrong in LeptonX, it'll be solved later:
image

@enisn enisn enabled auto-merge June 13, 2024 12:49
@ebicoglu ebicoglu removed the request for review from hikalkan June 13, 2024 12:50
@enisn enisn merged commit c7bc363 into abpframework:dev Jun 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CMS Kit: Approvement system for the comments
7 participants