-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMS Kit: Approvement system for the comments #19919
Conversation
...cms-kit/src/Volo.CmsKit.Admin.Application.Contracts/Volo/CmsKit/Admin/Comments/CommentDto.cs
Outdated
Show resolved
Hide resolved
modules/cms-kit/src/Volo.CmsKit.Domain.Shared/Volo/CmsKit/Comments/CommentApproveState.cs
Show resolved
Hide resolved
modules/cms-kit/src/Volo.CmsKit.Admin.Application/Volo.CmsKit.Admin.Application.csproj
Outdated
Show resolved
Hide resolved
modules/cms-kit/src/Volo.CmsKit.Admin.Web/Volo.CmsKit.Admin.Web.csproj
Outdated
Show resolved
Hide resolved
.../cms-kit/src/Volo.CmsKit.EntityFrameworkCore/Volo/CmsKit/Comments/EfCoreCommentRepository.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Comments that were previously visible on the screen should not disappear. The solution to this may be this: When a new comment arrives, if the approval system is turned off, this new comment is recorded as directly approved (IsApproved = true). If the confirmation system is on, it is recorded as null. Thus, if it is activated later, previous comments will be considered approved.
If the approval system is turned off, automatic approval will occur.
- I think it should be sent for approval when the comment is edited, CMS Kit - Improvement in editing approval system for comments #19976
Instead of doing this, I think we should also save the date when it's enabled, and start approvement from that day. It's not practical to hide all already seen comments, after enabling the comment approvement setting. |
For now, we are showing a warning when enabling settings. But we will take your feedback into consideration, if it is considered appropriate I will update it as you said, thanks @EngincanV 🙏 |
…d, IsApprove value defaults to true
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I click on comments awaiting approval, the page does not load
Resolves #17772