Resolved #1508 Adding cli namespace normalizer. #2190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reference: https://stackoverflow.com/questions/773557/which-characters-are-allowed-in-a-vs-project-name Reference: https://github.com/dotnet/templating/blob/dcf5adbd4b5665887f22ad19592dedfb9f1e1b68/src/Microsoft.TemplateEngine.Orchestrator.RunnableProjects/ValueForms/DefaultSafeNamespaceValueFormModel.cs#L35
mehmetuken
changed the title
yekalkan
requested changes
Nov 18, 2019
| return value; | ||
| } | ||
|
|
||
| value = Regex.Replace(value, @"(^\s+|\s+$)", ""); |
There was a problem hiding this comment.
I think "String.Trim()" does the same job and much easier to understand than a regex.
| @@ -40,6 +41,7 @@ public CommandLineArgs Parse(string[] args) | |||
|
|
|||
| if (!argumentList.Any()) | |||
| { | |||
| target = NamespaceHelper.NormalizeNamespace(target); | |||
There was a problem hiding this comment.
This normalizing should be done only when 'target' must fit the project name regex. If you make this normalization here, any command which is not related to project name regex will be effected.
So this normalization has to be moved to commands which takes a project name as 'target'.
yekalkan
approved these changes
Nov 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: https://stackoverflow.com/questions/773557/which-characters-are-allowed-in-a-vs-project-name
Reference: https://github.com/dotnet/templating/blob/dcf5adbd4b5665887f22ad19592dedfb9f1e1b68/src/Microsoft.TemplateEngine.Orchestrator.RunnableProjects/ValueForms/DefaultSafeNamespaceValueFormModel.cs#L35