Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audited*WithUser generic type wrong constraint. #2900

Merged
merged 1 commit into from Feb 24, 2020
Merged

Audited*WithUser generic type wrong constraint. #2900

merged 1 commit into from Feb 24, 2020

Conversation

maliming
Copy link
Member

Resolve #2624

@maliming maliming added this to the 2.2 milestone Feb 24, 2020
@hikalkan hikalkan merged commit 296c2db into dev Feb 24, 2020
@hikalkan
Copy link
Member

Thanks @maliming :)

@maliming maliming deleted the maliming/patch-2 branch February 24, 2020 07:36
@xkaede
Copy link

xkaede commented Feb 24, 2020

hi @maliming
Would you please make the properties of Audited*WithUser as virtual.Some of them are not virtual.
eg.

abp/framework/src/Volo.Abp.Ddd.Domain/Volo/Abp/Domain/Entities/Auditing/FullAuditedEntityWithUser.cs

Line 18 in 40bc8e3

public TUser Creator { get; set; }

maliming added a commit that referenced this pull request Feb 24, 2020
@maliming
Make entity property virtual.
a7d5cba 
#2900 (comment)
@maliming
Copy link
Member Author

hi @xkaede a7d5cba

@xkaede
Copy link

xkaede commented Feb 24, 2020

Thanks @maliming

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hikalkan hikalkan Awaiting requested review from hikalkan

Assignees
No one assigned
Labels
abp-framework breaking change effort-0.5
Projects
None yet
Milestone
2.2
Development

Successfully merging this pull request may close these issues.

FullAuditedAggregateRootWithUser generic type wrong constraint
3 participants
@maliming @hikalkan @xkaede