Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MongoDbRepository needs to filter when deleting entity based on Id. #3259

Merged
merged 1 commit into from
Apr 5, 2020
Merged

MongoDbRepository needs to filter when deleting entity based on Id. #3259

merged 1 commit into from
Apr 5, 2020

Conversation

maliming
Copy link
Member

Resolve #3256

@maliming maliming mentioned this pull request Mar 20, 2020
Closed
@maliming maliming requested a review from hikalkan March 20, 2020 10:53
@maliming
Copy link
Member Author

@hikalkan Should I open PR on the master branch? Or wait until v2.4?

@maliming maliming added this to the 2.4 milestone Mar 20, 2020
@hikalkan
Copy link
Member

Yes, please send to master.

@hikalkan hikalkan closed this Mar 20, 2020
@hikalkan hikalkan removed this from the 2.4 milestone Mar 20, 2020
@hikalkan hikalkan removed their request for review March 20, 2020 14:41
@maliming maliming deleted the maliming/mongodb-delete branch March 21, 2020 12:53
@maliming maliming restored the maliming/mongodb-delete branch April 3, 2020 09:16
@maliming
Copy link
Member Author

maliming commented Apr 3, 2020 •
edited

Let's move to 2.4.

#3288

@maliming maliming reopened this Apr 3, 2020
@maliming maliming added this to the 2.4 milestone Apr 3, 2020
@maliming maliming requested a review from hikalkan April 3, 2020 09:17
@hikalkan hikalkan merged commit 1e916d7 into dev Apr 5, 2020
@hikalkan hikalkan deleted the maliming/mongodb-delete branch April 6, 2020 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hikalkan hikalkan Awaiting requested review from hikalkan

Assignees
No one assigned
Labels
abp-framework bug
Projects
None yet
Milestone
2.4
Development

Successfully merging this pull request may close these issues.

Default MongoDB repository delete by id does not take into account ISoftDelete interface
2 participants
@maliming @hikalkan