Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a RemoteService tip to the module overriding doc #4054

Merged
merged 2 commits into from
Jun 1, 2020
Merged

Add a RemoteService tip to the module overriding doc #4054

merged 2 commits into from
Jun 1, 2020

Conversation

gdlcf88
Copy link
Contributor

@gdlcf88 gdlcf88 commented May 22, 2020

See #4052

@hikalkan hikalkan requested a review from maliming May 31, 2020 20:48
@hikalkan
Copy link
Member

@maliming can you check if they really generated (even if we use [Dependency(ReplaceServices = true)] and [ExposeServices(typeof(IdentityUserManager))]).

@maliming maliming merged commit 7735ccf into abpframework:dev Jun 1, 2020
@maliming maliming added this to the 2.9 milestone Jun 1, 2020
@gdlcf88 gdlcf88 deleted the AddTipToModuleOverridingDoc branch June 1, 2020 07:34
maliming added a commit that referenced this pull request Jun 1, 2020
@maliming
Update Customizing-Application-Modules-Overriding-Services.md
a1168d8 
#4054
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maliming maliming maliming approved these changes

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
2.9
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gdlcf88 @hikalkan @maliming