Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert c# type to typescript type. #4055

Merged
merged 1 commit into from
May 22, 2020
Merged

Conversation

maliming
Copy link
Member

@maliming maliming commented May 22, 2020

Resolve #4051

I am confused about this code. Will it cause problems if a class contains G/guid replaced by string?

eg public class MyGuidDto

if (baseTypeName.Contains("guid") || baseTypeName.Contains("Guid"))
{
	baseTypeName = "string";
}

https://github.com/abpframework/abp/pull/4055/files#diff-ae62d3da26b0d94a192555bce181d5a7R532-R535

@maliming maliming requested a review from erolarkat May 22, 2020 10:07
@maliming maliming added this to the 2.9 milestone May 22, 2020
@maliming
Copy link
Member Author

I think we can split the function of GenerateProxyCommand class into multiple methods or services, because it currently completes all operations in one method, it is difficult for other developers to quickly understand this class. : )

@erolarkat erolarkat merged commit 894682f into dev May 22, 2020
@erolarkat
Copy link
Contributor

Yes you are right. We have a plan to refactor the code into services and methods. You are also right about guid :)

@maliming maliming deleted the maliming/Cli-GenerateProxy-Patch branch May 22, 2020 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use generate-proxy get more error
2 participants