Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the ErrorMessage of StringLengthAttribute according to the situation. #4097

Merged
merged 2 commits into from
May 28, 2020
Merged

Change the ErrorMessage of StringLengthAttribute according to the situation. #4097

merged 2 commits into from
May 28, 2020

Conversation

maliming
Copy link
Member

Resolve #4094

It seems that only StringLengthAttribute is special, so we can change its ErrorMessage.

@maliming maliming added this to the 2.9 milestone May 26, 2020
@maliming maliming requested a review from hikalkan May 26, 2020 07:31
@hikalkan hikalkan merged commit 0302a4a into dev May 28, 2020
@hikalkan hikalkan deleted the maliming/StringLengthAttribute-ErrorMessage branch May 28, 2020 06:51
@hikalkan
Copy link
Member

Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hikalkan hikalkan Awaiting requested review from hikalkan

Assignees
No one assigned
Labels
abp-framework problem
Projects
None yet
Milestone
2.9
Development

Successfully merging this pull request may close these issues.

DataAnnotationsLocalization is not working as expected.
2 participants
@maliming @hikalkan