Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide npm error in GetInstalledNpmPackages method #4103

Merged
merged 1 commit into from
Jun 1, 2020
Merged

Hide npm error in GetInstalledNpmPackages method #4103

merged 1 commit into from
Jun 1, 2020

Conversation

gdlcf88
Copy link
Contributor

@gdlcf88 gdlcf88 commented May 26, 2020

Fixed #3889

@maliming maliming requested a review from yekalkan May 27, 2020 00:16
@maliming maliming added this to the 2.9 milestone May 27, 2020
@hikalkan
Copy link
Member

@yekalkan silently failing this effects the rest of the code?

@yekalkan
Copy link
Member

yekalkan commented Jun 1, 2020

@yekalkan silently failing this effects the rest of the code?

No. Maybe we should make '--silent' option a parameter of RunCmdAndGetOutput method.

@yekalkan yekalkan merged commit 3905f84 into abpframework:dev Jun 1, 2020
@gdlcf88 gdlcf88 deleted the patch-1 branch June 1, 2020 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yekalkan yekalkan yekalkan approved these changes

Assignees
No one assigned
Labels
abp-cli
Projects
None yet
Milestone
2.9
Development

Successfully merging this pull request may close these issues.

abp update error
4 participants
@gdlcf88 @hikalkan @yekalkan @maliming