added search box view component #4145
Conversation
| @@ -40,4 +40,8 @@ | |||
| <ProjectReference Include="..\Volo.Abp.AspNetCore.Mvc.UI.Widgets\Volo.Abp.AspNetCore.Mvc.UI.Widgets.csproj" /> | |||
| </ItemGroup> | |||
|
|
|||
| <ItemGroup> | |||
| <_ContentIncludedByDefault Remove="Pages\Shared\Components\AbpPageToolbar\AbpPageSearchBox\Default.cshtml" /> | |||
There was a problem hiding this comment.
What is _ContentIncludedByDefault?
| } | ||
| } | ||
|
|
||
| public class SearchBoxViewModel |
There was a problem hiding this comment.
If you remove parameters then this class can be removed.
| { | ||
| public string PlaceHolder { get; set; } | ||
|
|
||
| public async Task<IViewComponentResult> InvokeAsync( |
There was a problem hiding this comment.
No need to parameters, just use standard names.
| @@ -0,0 +1,11 @@ | |||
| | |||
| <form method="post" class="searchForm"> | |||
There was a problem hiding this comment.
We use kebab-case for CSS class names.
Rename to page-search-form (search-form is too general)
| | ||
| <form method="post" class="searchForm"> | ||
| <div class="input-group"> | ||
| <input class="form-control filterText" placeholder="Search"/> |
There was a problem hiding this comment.
- Rename
filterTexttopage-search-filter-text - Make placeholder localized
| { | ||
| public async Task<IViewComponentResult> InvokeAsync() | ||
| { | ||
| return await Task.FromResult(View("~/Pages/Shared/Components/AbpPageSearchBox/Default.cshtml")); |
There was a problem hiding this comment.
No need to make async if you simply return the view:
public IViewComponentResult Invoke()
There was a problem hiding this comment.
I tried to make invoke method as return type IViewComponentResult but I got error like this
thats why I create this method as async method
There was a problem hiding this comment.
public IViewComponentResult Invoke() should work (exactly like that, not public IViewComponentResult InvokeAsync())
There was a problem hiding this comment.
I fixed it, you can check it
|
|
||
| <form method="post" class="page-search-form"> | ||
| <div class="input-group"> | ||
| <input class="form-control page-search-filter-text" placeholder="@Model.PlaceHolder"> |
There was a problem hiding this comment.
I've wrtitten that it should be LOCALIZED, not "it should be parametric".
| @@ -0,0 +1,7 @@ | |||
| namespace Volo.Abp.AspNetCore.Mvc.UI.Theme.Shared.Pages.Shared.Components.AbpPageSearchBox | |||
| { | |||
| public class AbpSearchBoxViewModel | |||
There was a problem hiding this comment.
Delete this class! We don't want that parameter. It should be a standard text, but localized in the current language.
| @@ -1,30 +1,30 @@ | |||
| { | |||
| "culture": "de", | |||
| "texts": { | |||
| "InternalServerErrorMessage": "W�hrend Ihrer Anfrage ist ein interner Fehler aufgetreten!", | |||
| "ValidationErrorMessage": "Ihre Anfrage ist nicht g�ltig!", | |||
| "InternalServerErrorMessage": "W�hrend Ihrer Anfrage ist ein interner Fehler aufgetreten!", | |||
There was a problem hiding this comment.
I think there is a problem here. I see bad chars.
| { | ||
| public class AbpPageSearchBoxViewComponent : AbpViewComponent | ||
| { | ||
| public IViewComponentResult Invoke(string placeHolder) |
No description provided.