Split ICrudAppservice and implementations
#4346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. I will review. |
hikalkan
approved these changes
Jun 16, 2020
|
Thanks @NecatiMeral for your contribution. I reviewed and it seems OK. However, this is a critical change and I want to get a deeper review from @maliming and @liangshiw |
...rk/src/Volo.Abp.Ddd.Application.Contracts/Volo/Abp/Application/Services/ICreateAppService.cs
Outdated
Show resolved
Hide resolved
.../Volo.Abp.Ddd.Application.Contracts/Volo/Abp/Application/Services/ICreateUpdateAppService.cs
Outdated
Show resolved
Hide resolved
...work/src/Volo.Abp.Ddd.Application.Contracts/Volo/Abp/Application/Services/ICrudAppService.cs
Outdated
Show resolved
Hide resolved
.../src/Volo.Abp.Ddd.Application.Contracts/Volo/Abp/Application/Services/IReadOnlyAppService.cs
Show resolved
Hide resolved
.../src/Volo.Abp.Ddd.Application/Volo/Abp/Application/Services/AbstractKeyReadOnlyAppService.cs
Outdated
Show resolved
Hide resolved
.../src/Volo.Abp.Ddd.Application.Contracts/Volo/Abp/Application/Services/IReadOnlyAppService.cs
Outdated
Show resolved
Hide resolved
realLiangshiwei
approved these changes
Jun 22, 2020
|
hi @NecatiMeral I think we should use read-only repository in read-only application services. eg: |
|
hi @maliming, thanks for your review. This makes totally sense. I'll check the possibilities and update this PR. |
NecatiMeral
commented
Jun 25, 2020
...work/src/Volo.Abp.Ddd.Application/Volo/Abp/Application/Services/AbstractKeyCrudAppService.cs
Outdated
Show resolved
Hide resolved
…lication services Still using `protected new` on `CrudAppService` because the repository member in `AbstractKeyCrudAppService` has to be renamed to something like `AbstractKeyRepository`, which would be a breaking change. Renaming the repository in each descendant could lead to misunderstandings, since in `CrudAppService` descendants will be three repositories to choose from: `Repository`, `ReadOnlyRepository`, `AbstractKeyRepository`. Currently the user must only differ between `ReadOnlyRepository` and `Repository`. @maliming, can you review this?
maliming
approved these changes
Jun 30, 2020
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #4282
Updated
AbstractKeyCrudAppServiceto use the newly introducedAbstractKeyReadOnlyAppService.Implemented
ReadOnlyAppServiceto provide a easy point to implement own (readonly) services.I have not provided default implementations for
ICreateAppService,IUpdateAppServiceandIDeleteAppServicebecause this would lead to a load of duplicated code.Maybe the
CrudAppServiceimplementation should act as a aggregating application service which delegates the methods to the actual services implementation, this would create a new layer of complexity and breaking changes.This has to be discussed first.
The issues requirements are adressed.