Tenant modals validation #6035
Merged
Tenant modals validation #6035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hikalkan
approved these changes
Nov 3, 2020
cotur
suggested changes
Nov 3, 2020
| await AppService.DeleteDefaultConnectionStringAsync(TenantInfo.Id); | ||
| await CheckPolicyAsync(ManageConnectionStringsPolicyName); | ||
|
|
||
| if (TenantInfo.UseSharedDatabase || TenantInfo.DefaultConnectionString.IsNullOrWhiteSpace()) |
There was a problem hiding this comment.
You define as [Required] for TenantInfoModel.DefaultConnectionString, but here we control is that null or empty.
| @@ -93,6 +100,7 @@ public class TenantInfoModel | |||
|
|
|||
| public bool UseSharedDatabase { get; set; } | |||
|
|
|||
| [Required] | |||
There was a problem hiding this comment.
This may be nullable. Does not required.
There was a problem hiding this comment.
It's only run if the checkbox is ticked so I think it's best to be Required in this case
cotur
approved these changes
Nov 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #6026