Use EFCore.NamingConventions to rewrite the name #6287
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @scymen. We will check the PR. |
maliming
reviewed
Nov 23, 2020
Comment on lines
+38
to
+61
| public static void NamingConventionsRewriteName(this DbContextOptionsBuilder optionsBuilder, | ||
| string namingConvention = nameof(DbNamingConvention.Default), | ||
| CultureInfo culture = null) | ||
| { | ||
| switch (namingConvention) | ||
| { | ||
| case nameof(DbNamingConvention.Default): | ||
| break; | ||
| case nameof(DbNamingConvention.SnakeCase): | ||
| optionsBuilder.UseSnakeCaseNamingConvention(culture); | ||
| break; | ||
| case nameof(DbNamingConvention.LowerCase): | ||
| optionsBuilder.UseLowerCaseNamingConvention(culture); | ||
| break; | ||
| case nameof(DbNamingConvention.UpperCase): | ||
| optionsBuilder.UseUpperCaseNamingConvention(culture); | ||
| break; | ||
| case nameof(DbNamingConvention.UpperSnakeCase): | ||
| optionsBuilder.UseUpperSnakeCaseNamingConvention(culture); | ||
| break; | ||
| default: | ||
| break; | ||
| } | ||
| } |
There was a problem hiding this comment.
You can try to convert (namingConvention )stringto DbNamingConvention, and then reuse NamingConventionsRewriteName method.
Comment on lines
+63
to
+134
| public static void NamingConventionsRewriteName(this ModelBuilder modelBuilder, | ||
| string namingConvention = nameof(DbNamingConvention.Default), | ||
| CultureInfo culture = null) | ||
| { | ||
| if (namingConvention == nameof(DbNamingConvention.Default)) | ||
| { | ||
| return; | ||
| } | ||
|
|
||
| if (Enum.TryParse(namingConvention, out DbNamingConvention naming)) | ||
| { | ||
| NamingConventionsRewriteName(modelBuilder, naming, culture); | ||
| } | ||
| } | ||
|
|
||
| public static void NamingConventionsRewriteName(this ModelBuilder modelBuilder, | ||
| DbNamingConvention namingConvention = DbNamingConvention.Default, | ||
| CultureInfo culture = null) | ||
| { | ||
| if (namingConvention == DbNamingConvention.Default) | ||
| { | ||
| return; | ||
| } | ||
|
|
||
| INameRewriter nameRewriter = null; | ||
| culture = culture ?? CultureInfo.InvariantCulture; | ||
| switch (namingConvention) | ||
| { | ||
| case DbNamingConvention.Default: | ||
| break; | ||
| case DbNamingConvention.SnakeCase: | ||
| nameRewriter = new SnakeCaseNameRewriter(culture); | ||
| break; | ||
| case DbNamingConvention.LowerCase: | ||
| nameRewriter = new LowerCaseNameRewriter(culture); | ||
| break; | ||
| case DbNamingConvention.UpperCase: | ||
| nameRewriter = new UpperCaseNameRewriter(culture); | ||
| break; | ||
| case DbNamingConvention.UpperSnakeCase: | ||
| nameRewriter = new UpperSnakeCaseNameRewriter(culture); | ||
| break; | ||
| default: | ||
| break; | ||
| } | ||
|
|
||
| foreach (var entity in modelBuilder.Model.GetEntityTypes()) | ||
| { | ||
| entity.SetTableName(nameRewriter.RewriteName(entity.GetTableName())); | ||
|
|
||
| foreach (var property in entity.GetProperties()) | ||
| { | ||
| property.SetColumnName(nameRewriter.RewriteName(property.GetColumnName())); | ||
| } | ||
|
|
||
| foreach (var key in entity.GetKeys()) | ||
| { | ||
| key.SetName(nameRewriter.RewriteName(key.GetName())); | ||
| } | ||
|
|
||
| foreach (var key in entity.GetForeignKeys()) | ||
| { | ||
| key.SetConstraintName(nameRewriter.RewriteName(key.GetConstraintName())); | ||
| } | ||
|
|
||
| foreach (var index in entity.GetIndexes()) | ||
| { | ||
| index.SetName(nameRewriter.RewriteName(index.GetName())); | ||
| } | ||
| } | ||
|
|
||
| } |
There was a problem hiding this comment.
| /// | ||
| /// Default value: "Default". | ||
| /// </summary> | ||
| public static string DbNamingConvention = "Default"; |
There was a problem hiding this comment.
Use enum DbNamingConvention as type will better.
|
By the way, there are some bugs in EFCore.NamingConventions. We have to wait for its official version. https://github.com/efcore/EFCore.NamingConventions/issues?q=is%3Aissue+label%3Abug+milestone%3A5.0.0 |
ghost
closed this
ghost
deleted the
|
Hi, hasn't this feature been officially released? I am using version 4.2.2 now and have not found this feature yet |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to fix the issues #2131 & #2351 , use EFCore.NamingConventions to rewrite the name. Supported naming conventions: Default, SnakeCase, LowerCase, UpperCase, UpperSnakeCase.
Changed:
Add Volo.Abp.EntityFrameworkCore reference to EFCore.NamingConventions.
In the xxxDbContext.cs , enable rewrite name by the extension methods NamingConventionsRewriteName of class Volo.Abp.EntityFrameworkCore.DbNamingConventionRewriterExtensions.cs
Use outside the abp framework, set the name convensions at the beginning.