Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI- blazor bundle and minification support #6365

Merged
merged 10 commits into from
Dec 2, 2020
Merged

Conversation

ilkayilknur
Copy link
Contributor

@ilkayilknur ilkayilknur commented Nov 26, 2020

Resolves #6060

This PR adds bundling and minification support to the bundle command in ABP CLI.

You can specify -b parameter to bundle references or -m to bundle and minify references. You also need to specify -n parameter to define the file name for bundle files.

Examples
abp bundle -b -n "mybundle"
abp bundle -m -n "mybundle"

Missing Items

  • Add usage info
  • Test on MAC
  • Remove lepton theme reference from the contributor and see if theme changing works.

@ilkayilknur ilkayilknur marked this pull request as ready for review November 27, 2020 13:26
@ilkayilknur
Copy link
Contributor Author

ilkayilknur commented Nov 27, 2020

@hikalkan PR is ready for review. When we enabled the bundling on the pro template, the lepton theme doesn't work properly. We need to add it individually and specify id attribute. I think we should add a new property to the BundleDefinition like ExcludeFromBundle. What do you think?

@ilkayilknur ilkayilknur removed the request for review from hikalkan November 30, 2020 08:31
@hikalkan
Copy link
Member

hikalkan commented Dec 2, 2020

I merge this. Then I will have some improvements.

@hikalkan hikalkan merged commit a9f6c47 into dev Dec 2, 2020
@hikalkan hikalkan deleted the blazor-bundling-minification branch December 2, 2020 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bundling & Minification system for the Blazor UI
2 participants