Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spelling #6642

Merged
merged 2 commits into from
Dec 17, 2020
Merged

Spelling #6642

merged 2 commits into from
Dec 17, 2020

Conversation

274188A
Copy link
Contributor

@274188A 274188A commented Dec 15, 2020

removed cookie scheme null
fixed spelling

removed cookie scheme null
fixed spelling
@maliming maliming added this to the 4.1-preview milestone Dec 15, 2020
Copy link
Contributor

@gterdem gterdem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @274188A,

No, cookie scheme must be explicitly set to null to get it work since it adds its own cookie scheme otherwise. You can check it from Tratcher's comment here AzureAD/microsoft-identity-web#133 (comment).

Also I mentioned about it at the end of the section under Don't Forget To title with related link. If they change the behaviour in the future, we can also change it.

Thanks for spelling correction.
Can you update your PR to only include the spelling correction?

@274188A 274188A changed the title Cookie Scheme arg is optional but not not nullable Spelling Dec 16, 2020
@274188A
Copy link
Contributor Author

274188A commented Dec 16, 2020

@gterdem - reverted as requested

@hikalkan hikalkan merged commit 82a32d5 into abpframework:dev Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants