Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set to # only for null URL #6663

Merged
merged 2 commits into from
Dec 17, 2020
Merged

Set to # only for null URL #6663

merged 2 commits into from
Dec 17, 2020

Conversation

realLiangshiwei
Copy link
Member

No description provided.

@realLiangshiwei realLiangshiwei added this to the 4.1-preview milestone Dec 16, 2020
@enisn
Copy link
Member

enisn commented Dec 16, 2020

What is the main goal of this change?
Can you describe this PR?

@realLiangshiwei
Copy link
Member Author

What is the main goal of this change?
Can you describe this PR?

Sure, An empty string is a valid link for Blazor. so set URL value to # only for null URL.

About MenuItem.Url.TrimStart('/')

When deployed as a sub-application, like https://localhost.com/subapplication.

Suppose we have a menu URL is /home, It will generate the link https://localhost.com/home. so we need to remove / and It will generate the correct link https://localhost.com/subapplication/home

@enisn
Copy link
Member

enisn commented Dec 16, 2020 •
edited

Thank you @realLiangshiwei
It looks OK now

@hikalkan hikalkan merged commit 88f9b01 into dev Dec 17, 2020
@hikalkan hikalkan deleted the liangshiwei/patch-1 branch December 17, 2020 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enisn enisn enisn approved these changes

@hikalkan hikalkan Awaiting requested review from hikalkan

Assignees
No one assigned
Labels
ui-blazor
Projects
None yet
Milestone
4.1-preview
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@realLiangshiwei @enisn @hikalkan