Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalize ContainerName #6897

Merged
merged 5 commits into from Feb 26, 2021
Merged

Normalize ContainerName #6897

merged 5 commits into from Feb 26, 2021

Conversation

realLiangshiwei
Copy link
Member

Resolve #6887

@realLiangshiwei realLiangshiwei added this to the 4.2-preview milestone Dec 30, 2020
@hikalkan hikalkan modified the milestones: 4.2-final, 4.3-preview Jan 27, 2021
@hikalkan
Copy link
Member

I moved this to 4.3-preview milestone because it is making changes in the dev, not rel-4.2 branch.

@hikalkan
Copy link
Member

hikalkan commented Feb 9, 2021

Can you explain what this changes? As I see it extracts IBlobNormalizeNamingService. Does it change any behavior? Where did you force "Bucket names must begin and end with a letter or number" rule?

@realLiangshiwei
Copy link
Member Author

No, It does not change any behavior.
We can use BlobContainerNameAttribute to name the container and when passing parameters to the Blob provider, the container name will be normalized, this is expected. But some blob providers provide ContainerName configuration, like Azure provider: https://docs.abp.io/en/abp/latest/Blob-Storing-Azure#options.

I extracted IBlobNormalizeNamingService to normalize the container name in the blob provider: https://github.com/abpframework/abp/pull/6897/files#diff-c18a862ba915b26143f3d92db86d0ac18ca81b11fd505cd0cc018a037c151aadR101-R106

@hikalkan
Copy link
Member

@maliming it seems OK to me. Please you also review & merge ;)

@maliming maliming merged commit 80d73e7 into dev Feb 26, 2021
@maliming maliming deleted the liangshiwei/blob-patch-1 branch February 26, 2021 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hikalkan hikalkan hikalkan approved these changes

@maliming maliming maliming approved these changes

Assignees
No one assigned
Labels
abp-framework problem
Projects
None yet
Milestone
4.3-preview
Development

Successfully merging this pull request may close these issues.

ContainerName should conform to naming rules
3 participants
@realLiangshiwei @hikalkan @maliming