Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cms Kit - Change TagEntityTypeDefinition Configuration #7483

Merged
merged 3 commits into from Jan 28, 2021
Merged

Cms Kit - Change TagEntityTypeDefinition Configuration #7483

merged 3 commits into from Jan 28, 2021

Conversation

enisn
Copy link
Member

@enisn enisn commented Jan 27, 2021 •
edited

Closes #7443

@enisn enisn added this to the 4.3-preview milestone Jan 27, 2021
@enisn enisn self-assigned this Jan 27, 2021
ilkayilknur
ilkayilknur suggested changes Jan 28, 2021
View reviewed changes
Copy link
Contributor

@ilkayilknur ilkayilknur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

modules/cms-kit/src/Volo.CmsKit.Domain/Volo/CmsKit/Tags/TagEntityTypeDefinitionDictionary.cs Outdated Show resolved Hide resolved
@ilkayilknur ilkayilknur merged commit 0abb573 into dev Jan 28, 2021
@ilkayilknur ilkayilknur deleted the cms-kit/tag-definition-options branch January 28, 2021 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilkayilknur ilkayilknur ilkayilknur approved these changes

Assignees

@enisn enisn

Labels
abp-module-cms-kit
Projects
None yet
Milestone
4.3-preview
Development

Successfully merging this pull request may close these issues.

Designing a better solution to add entity types
2 participants
@enisn @ilkayilknur