Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Repository DeleteAsync and DeleteManyAsync methods #7543

Merged
merged 6 commits into from Feb 2, 2021

Conversation

olicooper
Copy link
Contributor

Note: This PR is branched from this other PR #7542 as it requires the fixes from it for the tests to pass.

This:

  • Adds RepositoryBase.DeleteManyAsync(predicate)
  • Calls DeleteManyAsync(predicate) in concrete DeleteAsync(predicate) implementations when possible

* Add RepositoryBase.DeleteManyAsync(predicate)
* Call DeleteManyAsync(predicate) in concrete DeleteAsync(predicate) implementations when possible
Requires this PR for tests to pass: abpframework#7542
@olicooper
Copy link
Contributor Author

Related #7453

@maliming maliming marked this pull request as ready for review February 2, 2021 01:13
@maliming maliming added this to the 4.3-preview milestone Feb 2, 2021
@maliming maliming self-requested a review February 2, 2021 01:13
@maliming maliming requested a review from enisn February 2, 2021 06:00
@maliming
Copy link
Member

maliming commented Feb 2, 2021

hi @enisn

Can you review this?

Copy link
Member

@enisn enisn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right

@maliming maliming merged commit 8cfc4d0 into abpframework:dev Feb 2, 2021
@maliming
Copy link
Member

maliming commented Feb 2, 2021

Thanks @olicooper

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants