Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CmsKit - Add missing Http method binding to TagDefinitions #7557

Merged
merged 1 commit into from Feb 2, 2021

Conversation

enisn
Copy link
Member

@enisn enisn commented Feb 1, 2021

Summary

Resolution of following error while generating swagger.json

SwaggerGeneratorException: Ambiguous HTTP method for action - Volo.CmsKit.Admin.Tags.TagAdminController.GetTagDefinitionsAsync (Volo.CmsKit.Admin.HttpApi). Actions require an explicit HttpMethod binding for Swagger/OpenAPI 3.0

Note: This method works now in dev branchs without any issue. But it doesn't fits OpenAPI 3.0 specifications and swagger json can't be generated. Existing method is used over dynamic proxies, so no expected break after changing it.

@enisn enisn added this to the 4.3-preview milestone Feb 1, 2021
@enisn enisn self-assigned this Feb 1, 2021
@ilkayilknur ilkayilknur merged commit 0be42b5 into dev Feb 2, 2021
@ilkayilknur ilkayilknur deleted the cms-kit/tags-endpoint-fix branch February 2, 2021 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants