Map ExtraProperties of an entity to regular properties of a type-safe dto #7666
Conversation
|
|
||
| foreach (var property in properties) | ||
| { | ||
| property.SetValue(source, source.ExtraProperties[property.Name]); |
There was a problem hiding this comment.
I think we should remove this property from source.ExtraProperties. No need to duplication. If we define a regular property, we want to use it instead of extra property.
Duplication is dangerous here. Because if we change one of them, the other one won't change.
|
Actually, we may do vice verse too. Map regular properties to extra properties. But, this time we should only copy the extra properties defined for the target class. I mean we define automapper config for ProductDto->Product mapping with extra properties, we can copy ProductDto.Price to Product.ExtraProperties["Price"] if we've defined the "Price" as an extra property for the Product (using the ObjectExtensionManager). We can reuse the same mapToRegularProperties, no need to define an additional option. Note: We can consider this as another issue/PR. Please make my change request and I merge this first ;) Thanks. |
|
Thanks! |
|
Will this support any form of conversion? For example we are using MongoDB and have extended the OrganizationUnit entity to include a collection which is loaded as a collection of bson values. |
Resolves #3128