Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added media to cms-kit #7685

Merged
merged 26 commits into from Feb 15, 2021
Merged

Added media to cms-kit #7685

merged 26 commits into from Feb 15, 2021

Conversation

cotur
Copy link
Contributor

@cotur cotur commented Feb 10, 2021

Closes: #7643

@cotur cotur added this to the 4.3-preview milestone Feb 10, 2021
@cotur cotur requested a review from enisn February 10, 2021 11:34
@ilkayilknur
Copy link
Contributor

ilkayilknur commented Feb 10, 2021 •
edited

Can you also implement this to the tui-editor file upload so that we can test the end-to-end solution?

@enisn
Copy link
Member

enisn commented Feb 15, 2021

scripts & styles from libs folder can't pass the CodeQL test. Is there any solution for that @cotur ?

@cotur
Copy link
Contributor Author

cotur commented Feb 15, 2021

@enisn it's not a problem but I'll check it.

@ilkayilknur ilkayilknur merged commit 4d44684 into dev Feb 15, 2021
@ilkayilknur ilkayilknur deleted the cotur/cms-kit/media branch February 15, 2021 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilkayilknur ilkayilknur ilkayilknur approved these changes

@enisn enisn enisn approved these changes

Assignees
No one assigned
Labels
abp-module-cms-kit feature
Projects
None yet
Milestone
4.3-preview
Development

Successfully merging this pull request may close these issues.

CMS Kit - Implement Media API Set
3 participants
@cotur @ilkayilknur @enisn