Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support extending a controller #7766

Merged
merged 7 commits into from Feb 26, 2021
Merged

Support extending a controller #7766

merged 7 commits into from Feb 26, 2021

Conversation

acjh
Copy link
Contributor

@acjh acjh commented Feb 17, 2021

Resolves #6288
Resolves #7698
Resolves #7721

Changes:

  • Remove existing controllers instead of the derived controller if ExposeService with IncludeSelf = true.
  • Only remove the derived controller if it has base controller models, since some third-party base controllers are non-abstract,
    e.g. DevExpress.AspNetCore.Reporting.WebDocumentViewer.WebDocumentViewerController (Replacing controller is not possible [BUG ?} #6288).
  • Fix typo of AccountController to MyAccountController in Customizing-Application-Modules-Overriding-Services.md.
  • Mention the behaviour for extending a controller in Customizing-Application-Modules-Overriding-Services.md.

@maliming maliming added this to the 4.3-preview milestone Feb 18, 2021
@maliming maliming self-requested a review February 18, 2021 01:04
@maliming
Copy link
Member

hi @acjh

Could you add some test controllers to the unit test to test this feature?
If you don't have much time, I can add that.

@acjh
Copy link
Contributor Author

acjh commented Feb 18, 2021

@maliming Sure, done.

@hikalkan hikalkan merged commit a4dffd3 into abpframework:dev Feb 26, 2021
@hikalkan
Copy link
Member

Thanks @acjh for your contribution. It is nice to see you here :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants