Improve MongoDbCoreRepositoryExtensions #7879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As same as abpframework#5697, and fix a bug.
PMExtra
commented
Mar 1, 2021
|
|
||
| return mongoDbRepository; | ||
| if (repository is IMongoDbRepository<TEntity> mongoDbRepository) return mongoDbRepository; | ||
| throw new ArgumentException("Given repository does not implement " + typeof(IMongoDbRepository<TEntity>).AssemblyQualifiedName, nameof(repository)); |
There was a problem hiding this comment.
This is just making it more readable and not change any logic.
PMExtra
commented
Mar 1, 2021
| { | ||
| return repository.ToMongoDbRepository().GetAggregateAsync(cancellationToken); |
There was a problem hiding this comment.
There is a recursive call because the IMongoDbRepository does not have the GetAggregateAsync method.
There was a problem hiding this comment.
There was a problem hiding this comment.
Sorry, I tested the code with 4.2.1 library so I missed the new feature. I will rollback it.
realLiangshiwei
approved these changes
Mar 1, 2021
|
Thanks @PMExtra |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As same as #5697