Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make AuthWrapperComponent replacable in account module #7990

Merged
merged 1 commit into from Mar 10, 2021
Merged

Make AuthWrapperComponent replacable in account module #7990

merged 1 commit into from Mar 10, 2021

Conversation

mtozlu
Copy link
Contributor

@mtozlu mtozlu commented Mar 8, 2021 •
edited

Resolves #7989
Maybe merged after #7861

@realLiangshiwei
Copy link
Member

Hi,

Thanks for your contributor, but your PR contains too many unwanted commits. could you send a new PR? thanks.

image

@mtozlu
Copy link
Contributor Author

mtozlu commented Mar 8, 2021

@realLiangshiwei Thanks for the review. The commits are not unwanted. This feature is branched from feat/volo-5292 because account module came back with that branch (it was deleted before). And the change i made is in account module.
So this PR can be merged after #7861 is merged. After #7861 is merged, this PR will contain a single commit.

@realLiangshiwei realLiangshiwei added this to the 4.3-preview milestone Mar 8, 2021
@realLiangshiwei
Copy link
Member

realLiangshiwei commented Mar 8, 2021 •
edited

Thanks for explanation.
waiting for #7861 merged

@realLiangshiwei realLiangshiwei marked this pull request as draft March 8, 2021 14:51
@mehmet-erim
Copy link
Contributor

Hi @mtozlu

#7861 is merged. But still showing many changes.

@mtozlu
Copy link
Contributor Author

mtozlu commented Mar 10, 2021

@mehmet-erim Thanks for the info.
It's clean now.

@mtozlu mtozlu marked this pull request as ready for review March 10, 2021 08:21
@mehmet-erim mehmet-erim merged commit 5ad302d into abpframework:dev Mar 10, 2021
@mehmet-erim
Copy link
Contributor

Thanks for the contribution 🙂

@mtozlu mtozlu deleted the feat/abp-7989 branch March 10, 2021 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mehmet-erim mehmet-erim mehmet-erim approved these changes

Assignees
No one assigned
Labels
ui-angular
Projects
None yet
Milestone
4.3-preview
Development

Successfully merging this pull request may close these issues.

Make AuthWrapperComponent replacable in account module
3 participants
@mtozlu @realLiangshiwei @mehmet-erim