Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set RedirectUri property of AuthenticationProperties. #8002

Merged
merged 3 commits into from Mar 10, 2021

Conversation

maliming
Copy link
Member

@maliming maliming commented Mar 9, 2021

This will make oidc redirect correctly.

@maliming maliming requested a review from gterdem March 9, 2021 10:05
@maliming maliming added this to the 4.3-preview milestone Mar 9, 2021
);
}

return Challenge(new AuthenticationProperties {RedirectUri = returnUrl}, ChallengeAuthenticationSchemas);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we discard returnUrlHash? Client side apps may be using hashed return urls, no?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed.

@maliming maliming requested a review from gterdem March 10, 2021 01:22
@gterdem gterdem merged commit 3959d9d into dev Mar 10, 2021
@gterdem gterdem deleted the maliming/ChallengeAccountController branch March 10, 2021 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants